fix(aqua): lock github_content raw URLs#10102
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Aqua backend to handle GithubContent package types separately from GithubArchive. It now ensures that GithubContent packages have a path specified, returning an error if it is missing, and resolves the correct GitHub content URL. Additionally, an end-to-end test has been added to verify the lockfile generation for aqua:github_content URLs. There are no review comments, and I have no feedback to provide.
Greptile SummaryThis PR fixes a bug where
Confidence Score: 5/5Safe to merge — the change is a targeted one-line split of a match arm with a corresponding e2e test. The fix is minimal and directly mirrors the already-correct get_url install path. The lock resolution for GithubArchive is untouched. The new GithubContent arm uses the same github_content_url helper and the same path-presence guard that the install path has used since the feature was introduced, so the two paths are now consistent. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(aqua): lock github_content raw URLs" | Re-trigger Greptile |
Summary
github_contentpackages with raw GitHub content URLs instead of archive URLspatherror in lock resolution that install resolution already usesaqua:awslabs/git-secrets@1.3.0lock outputDiscussion
Addresses #10003.
Tests
CARGO_TARGET_DIR=/home/risu/.cache/cargo-target/mise-409845c58888dcc6 MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run test:e2e e2e/cli/test_lockMISE_TRUSTED_CONFIG_PATHS="$PWD" mise run format