Skip to content

fix(aqua): lock github_content raw URLs#10102

Merged
jdx merged 1 commit into
jdx:mainfrom
risu729:fix/aqua-github-content-lock-url
May 28, 2026
Merged

fix(aqua): lock github_content raw URLs#10102
jdx merged 1 commit into
jdx:mainfrom
risu729:fix/aqua-github-content-lock-url

Conversation

@risu729

@risu729 risu729 commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • lock aqua github_content packages with raw GitHub content URLs instead of archive URLs
  • return the same missing-path error in lock resolution that install resolution already uses
  • add e2e coverage for aqua:awslabs/git-secrets@1.3.0 lock output

Discussion

Addresses #10003.

Tests

  • CARGO_TARGET_DIR=/home/risu/.cache/cargo-target/mise-409845c58888dcc6 MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run test:e2e e2e/cli/test_lock
  • MISE_TRUSTED_CONFIG_PATHS="$PWD" mise run format

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Aqua backend to handle GithubContent package types separately from GithubArchive. It now ensures that GithubContent packages have a path specified, returning an error if it is missing, and resolves the correct GitHub content URL. Additionally, an end-to-end test has been added to verify the lockfile generation for aqua:github_content URLs. There are no review comments, and I have no feedback to provide.

@greptile-apps

greptile-apps Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a bug where GithubContent-type aqua packages had their lock file URLs generated using github_archive_url (producing .tar.gz archive URLs) instead of github_content_url (producing raw.githubusercontent.com URLs). The fix splits the previously combined GithubArchive | GithubContent match arm and adds the same missing-path guard that the install-time get_url path already enforces.

  • src/backend/aqua.rs: Splits the lock URL resolution match arm so GithubContent calls github_content_url rather than github_archive_url, and bails with a clear error when path is absent — consistent with the existing get_url implementation.
  • e2e/cli/test_lock: Adds an end-to-end test using aqua:awslabs/git-secrets@1.3.0 that asserts the lock file contains a raw.githubusercontent.com URL and does not contain an archive tar.gz URL.

Confidence Score: 5/5

Safe to merge — the change is a targeted one-line split of a match arm with a corresponding e2e test.

The fix is minimal and directly mirrors the already-correct get_url install path. The lock resolution for GithubArchive is untouched. The new GithubContent arm uses the same github_content_url helper and the same path-presence guard that the install path has used since the feature was introduced, so the two paths are now consistent.

No files require special attention.

Important Files Changed

Filename Overview
src/backend/aqua.rs Splits the combined GithubArchive
e2e/cli/test_lock Adds an e2e test for aqua:awslabs/git-secrets to verify the lock file emits a raw.githubusercontent.com URL and does not contain an archive tarball URL.

Reviews (1): Last reviewed commit: "fix(aqua): lock github_content raw URLs" | Re-trigger Greptile

@risu729 risu729 marked this pull request as ready for review May 28, 2026 05:29
@jdx jdx merged commit a8087fd into jdx:main May 28, 2026
32 checks passed
@risu729 risu729 deleted the fix/aqua-github-content-lock-url branch May 28, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants