-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: watch cwds of dependencies #10054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
774da57
fix: account for dependency directories in watch mode
43081j 3c32483
fix: account for common ancestors to avoid abs paths
43081j 10d5991
chore: add debug log when source is absolute
43081j f55b71c
Merge branch 'main' into watch-cwds
43081j a45e593
chore: pr feedback
43081j cc12d55
chore: switch to warning for abs paths
43081j f004d38
feat: rework to account for cwd-escaping globs
43081j b3e7b2f
feat: handle empy sets of sources
43081j 787ea2d
fix: handle windows escapes
43081j a9f4248
fix: handle watching external directories
43081j c1e8171
chore: add a sleep loop instead of a constant sleep
43081j eeabdf5
chore: formatting
43081j File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # Regression: a task whose cwd is a subdirectory (`dir`) but whose `sources` | ||
| # escape that cwd via `..` must still be watched. The anchor/project-origin | ||
| # has to widen up to the common ancestor so watchexec's filter actually | ||
| # matches the out-of-cwd source file when it changes. | ||
|
|
||
| mise use -g watchexec | ||
|
|
||
| mkdir -p packages/foo shared/src | ||
|
|
||
| cat <<EOF >mise.toml | ||
| [tasks.build] | ||
| dir = "packages/foo" | ||
| sources = ["../../shared/src/*.ts"] | ||
| run = "echo built" | ||
| EOF | ||
|
|
||
| touch shared/src/index.ts | ||
|
|
||
| LOG_FILE=$(mktemp) | ||
| mise watch build >"$LOG_FILE" 2>&1 & | ||
| WATCH_PID=$! | ||
|
|
||
| trap 'kill $WATCH_PID' EXIT | ||
|
|
||
| # Wait for the initial run before asserting the re-run. | ||
| for _ in $(seq 1 40); do | ||
| grep -q "built" "$LOG_FILE" && break | ||
| sleep 0.5 | ||
| done | ||
| if ! grep -q "built" "$LOG_FILE"; then | ||
| fail "Initial run never produced output; got: $(cat "$LOG_FILE")" | ||
| fi | ||
|
|
||
| echo "" >"$LOG_FILE" # clear so we only capture the re-run | ||
|
|
||
| # Touch the source that lives *outside* the task's cwd. | ||
| touch shared/src/index.ts | ||
| for _ in $(seq 1 40); do | ||
| grep -q "built" "$LOG_FILE" && break | ||
| sleep 0.5 | ||
| done | ||
|
|
||
| if ! grep -q "built" "$LOG_FILE"; then | ||
| fail "Expected re-run after changing ../../shared/src source, got: $(tr -d '\0' <"$LOG_FILE")" | ||
| fi | ||
| ok "mise watch retriggers on cwd-escaping (..) source" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.