Skip to content

fix(completion): avoid network calls when generating completions #10010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
May 21, 2026
Merged

fix(completion): avoid network calls when generating completions #10010

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95c1573
fix(completion): resolve toolset offline
cursoragent May 19, 2026
2576e34
fix(completion): clarify offline resolution comment
cursoragent May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/cli/completion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::cmd::cmd;
use crate::config::Config;
use crate::toolset::ToolsetBuilder;
use crate::toolset::{ResolveOptions, ToolsetBuilder};
use clap::ValueEnum;
use clap::builder::PossibleValue;
use eyre::Result;
Expand Down Expand Up @@ -54,7 +54,15 @@ impl Completion {

async fn call_usage(&self, shell: Shell) -> Result<String> {
let config = Config::get().await?;
let toolset = ToolsetBuilder::new().build(&config).await?;
// Completion generation only needs enough of the local tool environment to find `usage`;
// offline resolution avoids shell-startup network fetches.
let toolset = ToolsetBuilder::new()
.with_resolve_options(ResolveOptions {
offline: true,
..Default::default()
})
.build(&config)
.await?;
let mut args = vec![
"generate".into(),
"completion".into(),
Expand Down
Loading