fix: install mise-shim.exe on Windows#476
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for mise-shim.exe on Windows by adding logic to download and install it from release archives if missing. It refactors version detection and improves temporary file management during the extraction process. Feedback suggests optimizing performance by avoiding redundant version checks and refactoring duplicated download and extraction logic into a shared utility function to improve maintainability.
Greptile SummaryThis PR fixes Windows
Confidence Score: 5/5Safe to merge — the change is narrowly scoped to Windows shim installation and does not touch any non-Windows code paths. The new helpers correctly handle all three Windows scenarios: fresh install (shim extracted from the same zip), cached install needing repair (version resolved from the binary when not provided), and already-complete installs (early exit). Non-Windows paths are unaffected by the early-return guards in every new function. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "refactor: share Windows zip extraction" | Re-trigger Greptile |
Summary
mise-shim.exebesidemise.exewhen extracting Windows mise release zipsmise.exebut are missingmise-shim.exeFixes #475.
Testing
npm run allactionlint