Skip to content

fix(ci): add gh auth setup-git to release-plz.sh #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
May 12, 2026
Merged

fix(ci): add gh auth setup-git to release-plz.sh #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/release-plz.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ if [ -n "$latest_release_version" ] && [ "$cur_pkg_version" = "$latest_release_v
git config user.name mise-en-dev
git config user.email 123107610+mise-en-dev@users.noreply.github.com

# Configure git to use gh's credential helper. The checkout step uses
# persist-credentials: false (per zizmor's artipacked audit), so the
# token isn't written to .git/config and raw `git push` would 403.
gh auth setup-git

@gemini-code-assist gemini-code-assist Bot May 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While gh auth setup-git correctly configures the credential helper for the default host, it is generally more robust in CI scripts to explicitly specify the hostname to avoid ambiguity or potential prompts in environments with multiple configured hosts.

Suggested change
gh auth setup-git
gh auth setup-git --hostname github.com


# Create a PR with the version bump
npm version "${version#v}" --no-git-tag-version

Expand Down
Loading