fix: use workspace-local mise dir on Windows for cache compatibility by jdx · Pull Request #437 · jdx/mise-action

jdx · 2026-04-11T14:22:23Z

Summary

On Windows, default mise data dir to GITHUB_WORKSPACE/.mise instead of LOCALAPPDATA\mise
Fixes @actions/cache saveCache failing with "Path Validation Error" when the cache path is on a different drive than GITHUB_WORKSPACE

Why

@actions/cache uses @actions/glob internally to resolve cache paths. On Windows CI runners, GITHUB_WORKSPACE is on D: while LOCALAPPDATA is on C:. The glob library can't resolve paths across drives, causing saveCache to throw when the cache is cold.

This has been a latent bug masked by warm caches on main — saveCache is only called on cache miss, and the Windows cache has been hitting from a previously-seeded value.

Test plan

Windows integration test passes (cache miss → save → no error)
Other platforms unaffected (Linux, macOS, Alpine)

🤖 Generated with Claude Code

Note

Low Risk
Low risk: changes are limited to extra diagnostic logging and CI debug settings, with no functional changes to installation or caching behavior.

Overview
Adds extra diagnostics for cache troubleshooting by logging the resolved mise cache path, platform/workspace info, and directory contents before calling @actions/cache.saveCache.

Updates the test workflow to run the action with a distinct cache_key_prefix and ACTIONS_STEP_DEBUG enabled to surface these logs in CI.

^{Reviewed by Cursor Bugbot for commit b8f8b69. Bugbot is set up for automated code reviews on this repo. Configure here.}

gemini-code-assist

Code Review

This pull request updates the miseDir function to use a workspace-local directory on Windows when GITHUB_WORKSPACE is defined, addressing potential cross-drive issues with GitHub Actions caching. Feedback indicates that the MISE_DATA_DIR environment variable must be explicitly exported when this local path is used to ensure the mise CLI and the action remain synchronized, preventing cache misses.

gemini-code-assist · 2026-04-11T14:24:13Z

+    if (workspace) {
+      return path.join(workspace, '.mise')
+    }


When defaulting to a workspace-local directory on Windows, it is necessary to export the MISE_DATA_DIR environment variable. Without this, the mise CLI will continue to use its internal default path (typically %LOCALAPPDATA%\mise), while the action will attempt to restore and save the cache from the workspace-local .mise directory. This mismatch results in the actual tool installations not being cached, as they will be installed in the default location instead of the one being tracked by the action.

if (workspace) { const dir = path.join(workspace, '.mise') core.exportVariable('MISE_DATA_DIR', dir) return dir }

greptile-apps · 2026-04-11T14:26:53Z

Greptile Summary

This PR adds diagnostic logging inside saveCache and enables step-debug settings in the test workflow to help reproduce and observe the Windows cross-drive cache failure. However, the core fix described in the title — changing miseDir() to return GITHUB_WORKSPACE/.mise instead of LOCALAPPDATA\\mise on Windows — is not present in the diff; the saveCache path validation error will still occur on cache miss.

P1: miseDir() still returns path.join(LOCALAPPDATA, 'mise') on Windows; the cross-drive @actions/cache path validation error is unresolved.
P2: cache_key_prefix: mise-debug-v1 permanently changes the CI cache namespace; should be reverted once debugging is complete.
P2: Diagnostic core.info statements (including directory listings) are unconditional in production; consider gating behind core.isDebug().

Confidence Score: 3/5

Not safe to merge as-is — the Windows cache fix described in the title is absent; the bug remains.

The PR title is 'fix: use workspace-local mise dir on Windows' but miseDir() is functionally unchanged on Windows. The cross-drive saveCache failure will still occur on cache miss. The changes present are diagnostic-only, with two P2 debug artifacts that should be cleaned up before the final merge.

src/index.ts — miseDir() Windows branch needs the actual fix; .github/workflows/test.yml — debug cache key prefix should be reverted.

Important Files Changed

Filename	Overview
src/index.ts	Adds diagnostic logging to saveCache and a blank line in miseDir(); the Windows path fix described in the PR title is absent — miseDir() still returns LOCALAPPDATA\mise on Windows.
.github/workflows/test.yml	Adds ACTIONS_STEP_DEBUG and cache_key_prefix: mise-debug-v1 for debugging; the debug cache key permanently changes the CI cache namespace if not reverted.
dist/index.js	Compiled bundle updated to reflect src/index.ts diagnostic logging additions.
package-lock.json	Removes libc fields from optional rollup platform packages; cosmetic lockfile change with no functional impact.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[run] --> B{cache enabled?}
    B -->|yes| C[restoreMiseCache]
    C --> D["miseDir() → saves as MISE_DIR state"]
    D --> E{Windows?}
    E -->|yes| F["LOCALAPPDATA\\mise ❌ still on C:"]
    E -->|no| G["~/.local/share/mise or XDG_DATA_HOME"]
    F --> H[core.saveState MISE_DIR = C: path]
    G --> H
    H --> I[setupMise / miseInstall]
    I --> J{cache_save?}
    J -->|yes| K[saveCache]
    K --> L["miseDir() → reads MISE_DIR state"]
    L --> M["cachePath = C:\\...\\mise"]
    M --> N["@actions/cache.saveCache ❌ cross-drive error on Windows"]

_{Reviews (3): Last reviewed commit: "fix: use workspace-local mise dir on Win..." | Re-trigger Greptile}

cursor · 2026-04-11T15:36:31Z

+        if (fs.existsSync(cachePath)) {
+            const contents = await fs.promises.readdir(cachePath);
+            core.info(`Cache dir contents: ${JSON.stringify(contents)}`);
+        }


Debug logging accidentally committed in saveCache

Medium Severity

Diagnostic core.info calls logging the cache path, its existence, platform, GITHUB_WORKSPACE, and full directory contents were added to saveCache. These are debug/investigation statements (not core.debug) that will produce verbose output for every user on every cache-miss run. This appears to be troubleshooting code for the Windows cross-drive issue that was accidentally included in the commit.

^{Reviewed by Cursor Bugbot for commit 121dc09. Configure here.}

cursor · 2026-04-11T15:36:31Z

            MY_ENV_VAR = "abc"
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          ACTIONS_STEP_DEBUG: true


ACTIONS_STEP_DEBUG permanently enabled in CI workflow

Low Severity

ACTIONS_STEP_DEBUG: true is set as a permanent environment variable on the test step. This enables verbose GitHub Actions step-level debug output for every CI run, not just during active debugging. This looks like a leftover from investigating the Windows caching issue described in the PR.

^{Reviewed by Cursor Bugbot for commit 121dc09. Configure here.}

@actions/cache uses @actions/glob internally to resolve cache paths, which fails when the path is on a different drive than GITHUB_WORKSPACE. On Windows CI runners, GITHUB_WORKSPACE is typically on D: while LOCALAPPDATA (the previous default) is on C:, causing saveCache to throw "Path Validation Error" on cold caches. Default to GITHUB_WORKSPACE/.mise on Windows so the cache path is always on the same drive as the workspace. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b8f8b69. Configure here.}

cursor · 2026-04-11T17:04:52Z

 async function saveCache(cacheKey) {
    await core.group(`Saving mise cache`, async () => {
        const cachePath = miseDir();
+        core.info(`Cache path: ${cachePath}`);


Described Windows miseDir fix is entirely missing

High Severity

The PR description states the fix is to "default mise data dir to GITHUB_WORKSPACE/.mise instead of LOCALAPPDATA\mise" on Windows, but miseDir() was never modified — it still returns path.join(LOCALAPPDATA, 'mise') on Windows. Only debug logging was added to saveCache. The actual fix that would resolve the cross-drive @actions/cache path validation error is absent from this commit.

Additional Locations (1)

dist/index.js#L81449-L81457

^{Reviewed by Cursor Bugbot for commit b8f8b69. Configure here.}

greptile-apps · 2026-04-11T17:06:00Z

  if (process.platform === 'win32' && LOCALAPPDATA)
    return path.join(LOCALAPPDATA, 'mise')


Windows fix is absent — cross-drive saveCache error persists

The PR title promises "use workspace-local mise dir on Windows for cache compatibility," but miseDir() is unchanged: it still returns path.join(LOCALAPPDATA, 'mise') on Windows. On GitHub-hosted Windows runners LOCALAPPDATA is on C: while GITHUB_WORKSPACE is on D:, so saveCache still passes a cross-drive path to @actions/cache, which triggers the "Path Validation Error" on every cold-cache run. The diagnostic logging added below will show the C:\… path, confirming the bug isn't fixed yet.

The intended fix — falling back to path.join(process.env.GITHUB_WORKSPACE!, '.mise') when on Windows — needs to be added here:

Suggested change

if (process.platform === 'win32' && LOCALAPPDATA)

return path.join(LOCALAPPDATA, 'mise')

if (process.platform === 'win32') {

const workspace = process.env.GITHUB_WORKSPACE

if (workspace) return path.join(workspace, '.mise')

if (LOCALAPPDATA) return path.join(LOCALAPPDATA, 'mise')

}

jdx · 2026-04-11T17:06:50Z

Not a pre-existing bug — Windows cache save works fine with ncc. The failure is specific to the rollup bundling in #436. Closing this and moving the fix there.

gemini-code-assist Bot reviewed Apr 11, 2026

View reviewed changes

cursor Bot reviewed Apr 11, 2026

View reviewed changes

Comment thread dist/index.js Outdated

greptile-apps Bot reviewed Apr 11, 2026

View reviewed changes

Comment thread src/index.ts Outdated

jdx force-pushed the fix/windows-cache-save branch from f991358 to 121dc09 Compare April 11, 2026 15:33

cursor Bot reviewed Apr 11, 2026

View reviewed changes

jdx force-pushed the fix/windows-cache-save branch from 121dc09 to b8f8b69 Compare April 11, 2026 17:02

cursor Bot reviewed Apr 11, 2026

View reviewed changes

greptile-apps Bot reviewed Apr 11, 2026

View reviewed changes

jdx closed this Apr 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: use workspace-local mise dir on Windows for cache compatibility#437

fix: use workspace-local mise dir on Windows for cache compatibility#437
jdx wants to merge 1 commit into
mainfrom
fix/windows-cache-save

jdx commented Apr 11, 2026 •

edited by cursor Bot

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 11, 2026

Uh oh!

Uh oh!

greptile-apps Bot commented Apr 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

cursor Bot Apr 11, 2026

Uh oh!

cursor Bot Apr 11, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Apr 11, 2026

Uh oh!

greptile-apps Bot Apr 11, 2026

Uh oh!

jdx commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		if (process.platform === 'win32' && LOCALAPPDATA)
		return path.join(LOCALAPPDATA, 'mise')

-  if (process.platform === 'win32' && LOCALAPPDATA)
-    return path.join(LOCALAPPDATA, 'mise')
+  if (process.platform === 'win32') {
+    const workspace = process.env.GITHUB_WORKSPACE
+    if (workspace) return path.join(workspace, '.mise')
+    if (LOCALAPPDATA) return path.join(LOCALAPPDATA, 'mise')
+  }

Uh oh!

Conversation

jdx commented Apr 11, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Test plan

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

cursor Bot Apr 11, 2026

Choose a reason for hiding this comment

Debug logging accidentally committed in saveCache

Uh oh!

cursor Bot Apr 11, 2026

Choose a reason for hiding this comment

ACTIONS_STEP_DEBUG permanently enabled in CI workflow

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Apr 11, 2026

Choose a reason for hiding this comment

Described Windows miseDir fix is entirely missing

Uh oh!

greptile-apps Bot Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

jdx commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jdx commented Apr 11, 2026 •

edited by cursor Bot

Loading

greptile-apps Bot commented Apr 11, 2026 •

edited

Loading