-
-
Notifications
You must be signed in to change notification settings - Fork 73
chore: switch analytics from gtm/goatcounter to plausible #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,24 +107,10 @@ export default defineConfig({ | |
| [ | ||
| "script", | ||
| { | ||
| async: "", | ||
| src: "https://www.googletagmanager.com/gtag/js?id=G-M7TEP8PKSE", | ||
| }, | ||
| ], | ||
| [ | ||
| "script", | ||
| {}, | ||
| `window.dataLayer = window.dataLayer || []; | ||
| function gtag(){dataLayer.push(arguments);} | ||
| gtag('js', new Date()); | ||
| gtag('config', 'G-M7TEP8PKSE');`, | ||
| ], | ||
| [ | ||
| "script", | ||
| { | ||
| "data-goatcounter": "https://jdx-hk.goatcounter.com/count", | ||
| async: "", | ||
| src: "//gc.zgo.at/count.js", | ||
| defer: "", | ||
| "data-domain": "pa-9rbZ17iM0rSRarywoulSW", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| "data-api": "https://shrill.en.dev/f5f1/event", | ||
| src: "https://shrill.en.dev/shrill/script.js", | ||
| }, | ||
| ], | ||
| // OpenGraph | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-domainlooks like a token, not a domain nameStandard Plausible Analytics expects
data-domainto be the registered site domain (e.g.hk.jdx.dev), not a token-style string likepa-9rbZ17iM0rSRarywoulSW. If theshrill.en.devproxy is configured to accept this identifier as-is, this is intentional — but if it forwards to a real Plausible instance, analytics events may be silently dropped if the site isn't registered under this value. Ispa-9rbZ17iM0rSRarywoulSWthe actual site ID registered in the Plausible instance behind the proxy, or should this be the site's hostname (e.g.hk.jdx.dev)?