Skip to content

fix(release): avoid duplicate sponsor blurbs#488

Merged
jdx merged 1 commit into
mainfrom
fix/release-sponsor-idempotent
May 3, 2026
Merged

fix(release): avoid duplicate sponsor blurbs#488
jdx merged 1 commit into
mainfrom
fix/release-sponsor-idempotent

Conversation

@jdx

@jdx jdx commented May 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Make the release sponsor-blurb append step idempotent
  • Leave communique-generated sponsor text unchanged when it is already present

Testing

  • actionlint .github/workflows/release-plz.yml
  • git diff --check

This PR was generated by Codex.


Note

Low Risk
Low risk workflow-only change that makes release-note editing idempotent by detecting an existing sponsor section before appending.

Overview
Makes the enhance-release workflow’s “Append en.dev sponsor blurb” step idempotent by fetching the current GitHub release body once, checking for the existing ## 💚 Sponsor aube header, and skipping the edit when it’s already present.

When absent, it reuses the fetched body and appends the sponsor section as before, preventing duplicate blurbs across reruns.

Reviewed by Cursor Bugbot for commit ae3bf33. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR makes the sponsor-blurb append step idempotent by caching the release body in $body, checking for an existing ## 💚 Sponsor aube heading with grep -Fqx, and exiting early if found. It also eliminates a redundant second gh release view call by reusing the cached value via printf '%s ' "$body".

Confidence Score: 5/5

Safe to merge — minimal, correct change to a single workflow step with no logic regressions.

The idempotency guard is logically correct: YAML indentation stripping ensures the heredoc emits ## 💚 Sponsor aube as an exact line, matching the -Fqx pattern. No security concerns, no regressions, one less API call.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/release-plz.yml Adds an idempotency guard to the 'Append en.dev sponsor blurb' step: fetches the release body once, exits early if the heading is already present, and reuses the cached body string instead of a second gh call.

Reviews (1): Last reviewed commit: "fix(release): avoid duplicate sponsor bl..." | Re-trigger Greptile

@jdx jdx merged commit f5115f6 into main May 3, 2026
20 checks passed
@jdx jdx deleted the fix/release-sponsor-idempotent branch May 3, 2026 03:53
@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Benchmark changes

Versions:

  • aube: 1.6.2 -> 1.7.0
  • pnpm: 11.0.3 -> 11.0.4

Public ratios: warm installs vs Bun 7x -> 4x; warm installs vs pnpm 11x -> 9x.

Benchmark aube bun pnpm
Fresh install (warm cache) 332ms -> 415ms (+25%) 2242ms -> 1614ms (-28%) 3500ms -> 3772ms (+8%)
CI install (warm cache, GVS disabled) 930ms -> 1467ms (+58%) 1447ms -> 1641ms (+13%) 2475ms -> 3722ms (+50%)
CI install (cold cache, GVS disabled) 4364ms -> 5519ms (+26%) 4083ms -> 5394ms (+32%) 5380ms -> 6438ms (+20%)

ae3bf33 vs b3ec965 | aube/bun/pnpm | 3 scenarios | 3 runs | 500mbit/50ms | generated by Codex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant