Address code review comments #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeratsingh
commented
Nov 3, 2020
keeratsingh
commented
- Remove COOKIE2_HEADER
- Store cookies in the concurrent hashmap in the factory for persistance.
- Added end to end test for cookie persistence
- Remove COOKIE2_HEADER - Store cookies in the concurrent hashmap in the factory for persistance. - Added end to end test for cookie persistence
keeratsingh
force-pushed
the
cookie-handling-review-comments
branch
from
d68bf93 to
8aa1ff7
Compare
jduo
reviewed
Nov 4, 2020
.../flight/flight-core/src/main/java/org/apache/arrow/flight/client/ClientCookieMiddleware.java
Outdated
Show resolved
Hide resolved
jduo
reviewed
Nov 4, 2020
java/flight/flight-core/src/test/java/org/apache/arrow/flight/client/TestCookieHandling.java
Show resolved
Hide resolved
jduo
reviewed
Nov 4, 2020
java/flight/flight-core/src/test/java/org/apache/arrow/flight/client/TestCookieHandling.java
Outdated
Show resolved
Hide resolved
- Fixed test cookieStaysAfterMultipleRequestsEndToEnd. - Cleanup TestCookieHandling resources.
jduo
reviewed
Nov 4, 2020
.../flight/flight-core/src/main/java/org/apache/arrow/flight/client/ClientCookieMiddleware.java
Outdated
Show resolved
Hide resolved
jduo
reviewed
Nov 4, 2020
.../flight/flight-core/src/main/java/org/apache/arrow/flight/client/ClientCookieMiddleware.java
Outdated
Show resolved
Hide resolved
java/flight/flight-core/src/test/java/org/apache/arrow/flight/client/TestCookieHandling.java
Outdated
Show resolved
Hide resolved
- Update TestCookieHandling to use the test Factory with the ability to intercept the returned ClientCookieMiddleware.
jduo
approved these changes
Nov 4, 2020
Owner
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.