Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to namespaced phpunit versions #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"php": ">=5.2.4"
},
"require-dev": {
"phpunit/phpunit": "3.7.*"
"phpunit/phpunit": "> 5.4.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PHPUnit requires php-5.6 at least.

We have two approaches about using namespace PHPUnit:

  • Using the PHPUnit ^4.8.36 version to support namespace PHPUnit.
  • Drop php-5.x supports and upgrade the PHPUnit version to ^6.5 at least.

},
"authors": [
{
Expand Down
4 changes: 3 additions & 1 deletion tests/SqlFormatterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// Force SqlFormatter to run in non-CLI mode for tests
SqlFormatter::$cli = false;

class SqlFormatterTest extends PHPUnit_Framework_TestCase {
use PHPUnit\Framework\TestCase;

class SqlFormatterTest extends TestCase {
protected $sqlData;

/**
Expand Down