This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Fix bulk fill for usage #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if there existed any notes in the target deck that didn't have one of the hanzi fields, the `get_hanzi` step would fail as a result of `cleanup` raising a `ValueError` if it received `text=None`. This PR modifies the logic so that presence of a `hanzi` field is verified before getting the `hanzi` itself. It also modifies the behavior such that cards that do not have usages filled are marked as failed. Otherwise, the user doesn't know why many cards did not have usages filled. Relevant to jdlorimer#177.
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if there existed any notes in the target deck that didn't
have one of the hanzi fields, the
get_hanzistep would fail as aresult of
cleanupraising aValueErrorif it receivedtext=None.This PR modifies the logic so that presence of a
hanzifield isverified before getting the
hanziitself.It also modifies the behavior such that cards that do not have usages
filled are marked as failed. Otherwise, the user doesn't know why many
cards did not have usages filled.
Relevant to #177.
Testing Strategy: All
unittesttests pass