Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add 'transform: translate(0)' to .nut-tab-pane #3130

Closed
wants to merge 1 commit into from

Conversation

ilk-1
Copy link

@ilk-1 ilk-1 commented Jul 6, 2024

这个 PR 做了什么?

修复tab-container顶层容器使用transform移动时,tab内部的fixed属性失效,导致布局错误的情况。

这个 PR 是什么类型?

  • [ ☑️] fix: bug 修复

这个 PR 涉及以下平台:

  • [ ☑️] NutUI H5 @nutui/nutui

这个 PR 是否已自测:

Summary by CodeRabbit

  • 样式
    • 为 TabPane 元素添加了 transform: translate(0); 样式属性。

Copy link

coderabbitai bot commented Jul 6, 2024

概述

src/packages/__VUE/tabpane/index.scss 文件中,添加了一个新的 CSS 属性 transform: translate(0);,该属性影响元素在非活动状态下的样式。

变更

文件路径 变更摘要
src/packages/__VUE/tabpane/index.scss 添加了 transform: translate(0); 属性,改变非活动状态的样式。

序列图

本次调整过于简单,因此不提供序列图。

诗歌

样式舞动轻如风,
平滑变换无影踪。
代码间,巧妙弄,
细微调整注新容。
兔子欢喜舞玲珑。 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dd6b2bd and 13f1bcf.

Files selected for processing (1)
  • src/packages/__VUE/tabpane/index.scss (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/packages/__VUE/tabpane/index.scss

@ilk-1
Copy link
Author

ilk-1 commented Jul 6, 2024

Close #3096

@ilk-1
Copy link
Author

ilk-1 commented Jul 7, 2024

@ilk-1 ilk-1 changed the title bugfix: add 'transform: translate(0)' to .nut-tab-pane bugfix: add 'transform: translate(0)' to .nut-tab-pane fix #3096 Jul 7, 2024
@ilk-1 ilk-1 changed the title bugfix: add 'transform: translate(0)' to .nut-tab-pane fix #3096 bugfix: add 'transform: translate(0)' to .nut-tab-pane Jul 7, 2024
@ilk-1
Copy link
Author

ilk-1 commented Jul 7, 2024

fixes #3096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant