Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): type props didnot work when equals number|digit #2563

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Aug 30, 2024

  • 日常 bug 修复

Summary by CodeRabbit

  • 新功能
    • 简化了 Input 组件的值处理逻辑,确保在所有环境中根据输入类型进行格式化。
  • 改进
    • 移除了环境类型检查,使得数字和数字输入的格式化逻辑在所有平台上都能一致执行。

Copy link

coderabbitai bot commented Aug 30, 2024

Walkthrough

此次更改涉及 Input 组件的逻辑,特别是在处理 value 时对其 type 的处理。原有实现中包含了环境类型检查(getEnv() === ENV_TYPE.WEB),以决定在 type 为 'number' 或 'digit' 时如何格式化 value。此次更改移除了该检查,使格式化逻辑不再受环境影响,简化了控制流程。

Changes

文件路径 更改摘要
src/packages/input/input.taro.tsx 移除环境类型检查,简化 value 格式化逻辑,确保在所有环境中都调用格式化函数。

Poem

🐇 在草地上跳跃欢快,
输入框中新变化,
不再分环境与类型,
格式化随心所欲来。
兔子乐在其中,
代码如春风拂面,
让我们一起欢庆这新篇! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.20%. Comparing base (902f918) to head (648a520).
Report is 8 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2563   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files         217      217           
  Lines       17801    17801           
  Branches     2573     2573           
=======================================
  Hits        14812    14812           
  Misses       2984     2984           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-huxiyang Alex-huxiyang linked an issue Aug 30, 2024 that may be closed by this pull request
@oasis-cloud oasis-cloud merged commit 3699c95 into jdf2e:next Sep 6, 2024
5 checks passed
This was referenced Sep 12, 2024
@Alex-huxiyang Alex-huxiyang deleted the hxy/weapp/input branch November 19, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input在weapp环境中无法限制输入内容为数字
2 participants