-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New target param in 1.1 causes plug in to fail #5
Comments
+1 |
jdee
added a commit
that referenced
this issue
Apr 21, 2017
jdee
added a commit
that referenced
this issue
Apr 21, 2017
fix #5: Bad key for :target option. Added unit tests for options.
Thanks for reporting this. Obviously I could stand to test better. I've added some unit tests for the options that would have caught the problem. And thanks for using the plugin. I hope it's been working well for you. |
1.1.1 has been released with this fix. |
Works perfect now, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The new target param added in the last release broke my update_settings_bundle fastlane plugin. Have already verified it works with 1.0 and fails after upgrading to 1.1. The issue is that the new param's key to fastlane is a duplicate of an existing key 'file':
I believe the key: should be key: :target instead of :file since :file is an existing param in 1.0
The text was updated successfully, but these errors were encountered: