Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New target param in 1.1 causes plug in to fail #5

Closed
stonedauwg opened this issue Apr 21, 2017 · 4 comments
Closed

New target param in 1.1 causes plug in to fail #5

stonedauwg opened this issue Apr 21, 2017 · 4 comments

Comments

@stonedauwg
Copy link

stonedauwg commented Apr 21, 2017

The new target param added in the last release broke my update_settings_bundle fastlane plugin. Have already verified it works with 1.0 and fails after upgrading to 1.1. The issue is that the new param's key to fastlane is a duplicate of an existing key 'file':

FastlaneCore::ConfigItem.new(key: :file,
            env_name: "SETTINGS_BUNDLE_TARGET",
            description: "An optional target name from the project",
            optional: true,
            type: String)

I believe the key: should be key: :target instead of :file since :file is an existing param in 1.0

@jeff-jk
Copy link
Contributor

jeff-jk commented Apr 21, 2017

+1

@jdee jdee closed this as completed in 313ee77 Apr 21, 2017
jdee added a commit that referenced this issue Apr 21, 2017
fix #5: Bad key for :target option. Added unit tests for options.
@jdee
Copy link
Owner

jdee commented Apr 21, 2017

Thanks for reporting this. Obviously I could stand to test better. I've added some unit tests for the options that would have caught the problem.

And thanks for using the plugin. I hope it's been working well for you.

@jdee
Copy link
Owner

jdee commented Apr 21, 2017

1.1.1 has been released with this fix.

@stonedauwg
Copy link
Author

Works perfect now, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants