Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Link text unclear" should detect image links as image links #1

Closed
kevinbarabash opened this issue Jun 8, 2015 · 3 comments · Fixed by #38
Closed

"Link text unclear" should detect image links as image links #1

kevinbarabash opened this issue Jun 8, 2015 · 3 comments · Fixed by #38
Labels

Comments

@kevinbarabash
Copy link

Right now it comes up with the following message for the image link on the gh-pages.

The text " " is unclear without context
and may be confusing to screen readers. Consider
rearranging the <a></a> tags or
including special screen reader text.

It would be nice if it said something like:

You have an image link without alt text.  Please add an alt attribute to the img tag.
@jdan
Copy link
Owner

jdan commented Jun 8, 2015

This is an outstanding bug for Accessibility Developer Tools. GoogleChrome/accessibility-developer-tools#156

We can remedy it by adding an extra check for getTextFromDescendantContent until they fix, though :)

@kevinbarabash
Copy link
Author

I didn't realize it was a bug b/c when I was looking at it before you added alt text to the image on gh-pages. In addition to fixing the bug, I was thinking it would be nice to have an error message that calls out that's it's an image link issue. It's really a nice to have. Since I'm interested in it, I'll look into and send you pull request when I have some time.

@jdan
Copy link
Owner

jdan commented Jun 9, 2015

I was thinking it would be nice to have an error message that calls out that's it's an image link issue

Great idea, I imagine this is a common use-case.

@jdan jdan removed the jank label Jun 9, 2015
@jdan jdan added the in review label Jul 8, 2015
@jdan jdan closed this as completed in #38 Jul 8, 2015
jdan added a commit that referenced this issue Jul 8, 2015
Added image alt-text detection to the link text plugin - Fixes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants