-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Link text unclear" should detect image links as image links #1
Comments
This is an outstanding bug for Accessibility Developer Tools. GoogleChrome/accessibility-developer-tools#156 We can remedy it by adding an extra check for getTextFromDescendantContent until they fix, though :) |
I didn't realize it was a bug b/c when I was looking at it before you added alt text to the image on gh-pages. In addition to fixing the bug, I was thinking it would be nice to have an error message that calls out that's it's an image link issue. It's really a nice to have. Since I'm interested in it, I'll look into and send you pull request when I have some time. |
Great idea, I imagine this is a common use-case. |
Added image alt-text detection to the link text plugin - Fixes #1
Right now it comes up with the following message for the image link on the gh-pages.
It would be nice if it said something like:
The text was updated successfully, but these errors were encountered: