Pass options to slide template rendering #178
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes the
options
down to the slide template, so it's easier to extend it with new (customisable) functionality. Right now only the layout has access to the options, limiting where you can place new elements.Additionally made sure that the default values for
options.controls
andoptions.progress
are properly passed down (i.e.true
when not defined explicitly) to layout as well.It might make sense to remove the passing down of
controls
andprogress
to the slide template as well, but I figured leaving it in is a bit better for backwards-compatibility.