-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/added active_rules and inactive_rules to qualityprofile #241
base: master
Are you sure you want to change the base?
Feature/added active_rules and inactive_rules to qualityprofile #241
Conversation
…ube_qualityprofile resource
…ube_qualityprofile resource
…ube_qualityprofile resource
Hi - see discussion here: #54 on a similar approach and why it was rejected. The discussion I linked you to describes an approach I have used in the past - build a list of rules from the Sonar Way profile, minus ones I don’t want at all and with some customised where required, then for-each the list and add them as individual resources. I would prefer it if the qualityprofile resource followed a similar model to the qualitygate one: https://registry.terraform.io/providers/jdamata/sonarqube/latest/docs/resources/sonarqube_qualitygate where better model the relationships between resources rather than being a thin wrapper around the existing Sonar API but that is a bigger refactor for another day.. |
Thanks for the feedback |
Hi
How does a user know this is the case?
It seems like this will simply cause confusion and open up a load of questions with non-obvious answers as well as potentially conflicting with the existing
I'm not sure what you mean by a "dynamic" environment? In my case what I did was create one |
Hi there. short: I need this or similar feature too. @freeranger you mention:
This approach looks obvious, but how it works on every SonarQube update with new rules? For example: you have three C++ projects, but they are for different platforms and different compilers (welcome to embedded world). A you going to make three profiles almost identical? Just curious, as I'm setting SonarQube right now and new MISRA rules comes every release. So, from my use case I see it like the following:
From the terraform perspective I expect similar approach. If Unfortunately, I used to exclude rules via |
Added active_rules and inactive_rules list to qualityprofile resource:
Both attributes have
ForceNew: true
, so rule activation/deactivation could lead to consistent results based on the default quality profile.