Reach > 90% coverage and add Integration Testing #709
Conversation
jdalrymple
changed the title
The openpgp tests have been giving me trouble, and we need to verify the typing is correct for the exports. I thought i had it working, but apparently not. It should take in a dictionary of constructors and return a dictionary of constructors. Any typescript gurus wanna help hehe? This is what i was referencing the code from |
jdalrymple
force-pushed
the
integration-tests
branch
from
b643a2b to
e9899cf
Compare
jdalrymple
changed the title
jdalrymple
force-pushed
the
integration-tests
branch
from
e9899cf to
a651f83
Compare
jdalrymple
force-pushed
the
master
branch
2 times, most recently
from
09fb950 to
176dadf
Compare
jdalrymple
force-pushed
the
integration-tests
branch
3 times, most recently
from
75a037a to
ed23069
Compare
|
Looks like many parallel calls to the Gitlab instance is resulting in Error 502 Bad Gateway errors. Maybe i have to run these in band? |
|
Hmm, how can i change the organization of the tests. Right now when i tests the services in the gitbeaker-node package, none of the files from gitbeaker-core are registered as being covered. I guess since its an imported library. If i moved the tests to gitbeaker-core i would have to defined a requester for the tests, plastically recreating gitbeaker-node just for tests. :/ Ideas? @jetersen Maybe you have some ideas? |
|
@jdalrymple I would again advice to use the docker healthy status instead of waiting. We been using it very successfully over at https://github.com/nmklotas/GitLabApiClient and never had issue with gitlab not being ready. The code that does the magic: The actual code that does the magic: https://github.com/mariotoffia/FluentDocker/blob/d066518cd2190bb16ccb0d1e635d3883d67fbaa7/Ductus.FluentDocker/Services/Extensions/ContainerExtensions.cs#L252-L282 the actual actual health check: the actual actual code for the health check: |
|
Ill look into switching it up! @jetersen Any thoughts on the test locations? |
|
There must be a way in jest to register internal library especially as jest itself is a mono repo. https://github.com/facebook/jest/tree/master/packages |
|
jestjs/jest#2418 might be what your looking for. |
jdalrymple
force-pushed
the
integration-tests
branch
from
546a2de to
4d4e82d
Compare
Added the subscribe method Added a few default values to avoid having to pass empty objects Adding unit tests
jdalrymple
force-pushed
the
integration-tests
branch
from
746ae45 to
0b2cd3c
Compare
jdalrymple
changed the title
|
At 84% so far! only 6% more to go 🙌 |
|
🚀 PR was released in |
fixes #686
fixes #698
fixes #309