Merge to master #187
Merged
Merge to master #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Utah teapot and Stanford bunny models to the set of objects displayed.
Allow lower precision with micromath and fallback.
The generic Mul for Scalar impl violated orphan rules, but used to be accepted by rustc due to a bug. Replace the impl with separate concrete impls for f32, i32, and u32. See rust-lang/rust#124559 for more info.
* Change VecN type aliases to always be in Real<N, B>, generic over B. This better matches their intended semantics as specifically Cartesian vectors. For example, SphericalVec and Vec3 are now always distinct types. Also, absurd types like Vec3<Real<2>> are no longer possible. * Change vecN functions to be generic over B, matching their respective VecN. This removes the need for most uses of .to(), at the expense of sometimes being unable to infer B. * Turn generic Vec4 to ProjVec4 specifically, with little need for Cartesian 4-vectors at least for now. Remove vec4 functions as unneeded.
Technically these should be called "points".
This adds add/sub operators to Vec2u.
Also add tests for indexing.
Remove the with_mode constructor.
The seven-parameter render() function calls were not exactly the best.
Add type aliases and move object creation into functions
Take it as a parameter instead. Also rename all variables named `gen` for compatibility with Rust 2024 which makes `gen` a keyword.
Yields pairs of samples, naturally.
Parameterizing on the fragment type was needlessly generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.