Skip to content

Add regtest for SCRIPMPI#3

Merged
jcwarner-usgs merged 14 commits into
jcwarner-usgs:developfrom
MatthewMasarik-NOAA:regtest/scrip-mpi
Mar 26, 2025
Merged

Add regtest for SCRIPMPI#3
jcwarner-usgs merged 14 commits into
jcwarner-usgs:developfrom
MatthewMasarik-NOAA:regtest/scrip-mpi

Conversation

@MatthewMasarik-NOAA
Copy link
Copy Markdown
Collaborator

Pull Request Summary

Provides a small multi-grid regtest to exercise SCRIPMPI functionality.

Description

  • Provide a detailed description of what this PR does.
    • Adds a regtest for SCRIPMPI.
  • What bug does it fix, or what feature does it add?
    • Feature demonstration is added.
  • Is a change of answers expected from this PR?
    • No.

Please also include the following information:

  • Add any suggestions for a reviewer
  • Mention any labels that should be added: enhancement, new feature.
  • Are answer changes expected from this PR? No.

Issue(s) addressed

  • Please list any issues associated with this PR, including those the PR will fix/close. For example:
    NA

Commit Message

Add regtest for SCRIPMPI

Check list

Testing

  • How were these changes tested?
    • Matrix. Develop vs. PR branch confirms no answers change, PR vs. PR checks the new regtest reproduces.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    • No. A new regtest was added.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    • Hera / intel.
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    • Only the known non-b4b's.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

develop vs. pr

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (13 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (9 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)
 
**********************************************************************
************************ identical cases *****************************
**********************************************************************

dev.matrixCompSummary.txt
dev.matrixCompFull.txt
dev.matrixDiff.txt

pr vs. pr

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (13 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (13 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (2 files differ)
 
**********************************************************************
************************ identical cases *****************************
**********************************************************************

pr.matrixCompSummary.txt
pr.matrixCompFull.txt
pr.matrixDiff.txt

mingchen-NOAA and others added 14 commits March 10, 2025 12:38
To calculate the increment of spectrum, we should use the source term VSTR rather than VDTR
Typo in output.tex file is fixed to resolve build issue.
…bose=2 output (NOAA-EMC#1392)

* Add a new Angular Distance distance calculation (in degrees) routine in w3servmd and use this method in ww3_bounc to more robustly calculate spherical distances between geographic locations. This commit also adds VERBOSE=2 diagnostic output. VERBOSE=2 was previously unused.

* Corrected variable description

---------

Co-authored-by: Ty Hesser <thesser1@gmail.com>
@MatthewMasarik-NOAA
Copy link
Copy Markdown
Collaborator Author

@jcwarner-usgs there's a number of changes due to several commits to the develop branch in the interim. The main changes for this PR were to: regtests/bin/matrix.base, regtests/mww3_test_02/info, regtests/mww3_test_02/input/switch_PR3_UNO_SCRIPMPI.

@MatthewMasarik-NOAA
Copy link
Copy Markdown
Collaborator Author

I should have mentioned to sync before merging this PR, that will isolate these changes.

@jcwarner-usgs jcwarner-usgs merged commit b40fecc into jcwarner-usgs:develop Mar 26, 2025
@MatthewMasarik-NOAA MatthewMasarik-NOAA deleted the regtest/scrip-mpi branch April 30, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants