Improve feedback stretch markers #1150
Conversation
…uring playback is enabled
|
Build succeeded! Build osara pr1150-1596,0756ccb0 completed (commit 0756ccb013 by @ScottChesworth) |
| } | ||
| int oldCount = 0; | ||
| for (int i = 0; i < itemCount; ++i) { | ||
| MediaItem* item = GetSelectedMediaItem(nullptr, i); |
There was a problem hiding this comment.
Just to clarify, these commands definitely insert stretch markers across all selected items? I guess that makes sense and we just never supported this properly, but I just wanted to check.
| } | ||
| } else { | ||
| // Translators: Reported when one or more stretch markers are removed. {} will be replaced by the number of stretch markers, EG "2 stretch markers removed". | ||
| outputMessage(format( |
There was a problem hiding this comment.
Is it intentional that we respect shouldReportTimeMovement for addition, but not removal? I guess I kinda get this - you might well add them while playing, but you're less likely to remove them while playing, since you have to move to the marker first anyway - but I wanted to check because it does feel asymmetric.
| @@ -4273,6 +4303,7 @@ void cmdRemoveFocus(Command* command) { | |||
| cmdhRemoveItems(40006); // Item: Remove items | |||
| break; | |||
| case FOCUS_MARKER: | |||
|
|
|||
| @@ -4282,7 +4313,7 @@ void cmdRemoveFocus(Command* command) { | |||
| cmdDeleteTimeSig(nullptr); | |||
| break; | |||
| case FOCUS_STRETCH: | |||
| cmdRemoveStretch(nullptr); | |||
| cmdhAddOrRemoveStretch(41859); | |||
| {MAIN_SECTION, {{0, 0, 41859}, nullptr}, nullptr, cmdRemoveStretch}, // Item: remove stretch marker at current position | ||
| {MAIN_SECTION, {{0, 0, 41842}, nullptr}, nullptr, cmdAddOrRemoveStretch}, // Item: Add stretch marker at cursor | ||
| {MAIN_SECTION, {{0, 0, 41859}, nullptr}, nullptr, cmdAddOrRemoveStretch}, // Item: remove stretch marker at current position | ||
| {MAIN_SECTION, {{0, 0, 41844}, nullptr}, nullptr, cmdAddOrRemoveStretch}, // Item: Remove all stretch markers |
There was a problem hiding this comment.
Do either of these need a readme update?
Make OSARA report the addition of stretch markers when Report time movement during playback/recording is enabled in Config. Requested on RWP.