Make xbanish C99 compliant #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-R-K
reviewed
Apr 12, 2022
xbanish.c
Outdated
| #include <X11/Xlib.h> | ||
| #include <X11/Intrinsic.h> |
There was a problem hiding this comment.
Hmm, I remember getting a failed compilation report due to this. It includes the header but doesn't actually link against the library.
https://bugs.gentoo.org/806258#c3
| @@ -15,16 +15,17 @@ | |||
| * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. | |||
| */ | |||
|
|
|||
| #define _POSIX_C_SOURCE 2 | |||
There was a problem hiding this comment.
IMO it's better to define feature test macros in the Makefile under CPPFLAGS variable. But since it's a single file source, probably doesn't matter much.
|
damn, and I remember going over the diff multiple times making sure I didnt accidentally pull in more junk after writing out the original alarm related signal mess. shame. must've steered too much on suggested changes |
Co-authored-by: N-R-K <[email protected]>
|
Should be fine to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.