Add bond migration

[cfconrad]

Problem

Upstream bonding was finally merged and now we can re-implement the migrate-wicked side.

Testing

• Added a new unit test

[jcronenberg]

Suggested change

	if let Some(dummy) = &self.dummy {
	if let Some(address) = &dummy.address {
	connection.mac_address = MacAddress::from_str(address)?;
	}
	} else if let Some(ethernet) = &self.ethernet {
	if let Some(ethernet) = &self.ethernet {
	if let Some(address) = &ethernet.address {
	connection.mac_address = MacAddress::from_str(address)?;
	}
	}
	if self.dummy.is_some() {
	if let Some(dummy) = &self.dummy {
	if let Some(address) = &dummy.address {
	connection.mac_address = MacAddress::from_str(address)?;
	}
	connection.config = model::ConnectionConfig::Dummy
	} else if let Some(bond) = &self.bond {
	if let Some(address) = &bond.address {
	connection.mac_address = MacAddress::from_str(address)?;
	}
	connection.config = bond.into()
	} else {
	connection.config = model::ConnectionConfig::Ethernet
	};
	if let Some(ethernet) = &self.ethernet {
	if let Some(address) = &ethernet.address {
	connection.mac_address = MacAddress::from_str(address)?;
	}
	connection.config = model::ConnectionConfig::Ethernet
	} else if let Some(dummy) = &self.dummy {
	if let Some(address) = &dummy.address {
	connection.mac_address = MacAddress::from_str(address)?;
	}
	connection.config = model::ConnectionConfig::Dummy
	} else if let Some(bond) = &self.bond {
	if let Some(address) = &bond.address {
	connection.mac_address = MacAddress::from_str(address)?;
	}
	connection.config = bond.into()
	};

and maybe some DRY before we repeat it for every connection type:

macro_rules! ADD_MAC {
    ($connection:expr, $config:expr) => {
        if let Some(address) = &$config.address {
            $connection.mac_address = MacAddress::from_str(address)?;
        }
    };
}
...
        if let Some(ethernet) = &self.ethernet {
            ADD_MAC!(connection, ethernet);
            connection.config = model::ConnectionConfig::Ethernet
        }
...

[cfconrad]

WDYT of

impl TryFrom<&Option<String>> for MacAddress {
    type Error = InvalidMacAddress;

    fn try_from(value: &Option<String>) -> Result<Self, Self::Error> {
        match &value {
            Some(str) => MacAddress::from_str(str),
            None => Ok(Self::Unset)
        }
    }
}

[jcronenberg]

Sure, should also work if you prefer it.

[cfconrad]

I finally go with

#serde(default)
address: String,

which lead to empty string if it isn't in xml...

[jcronenberg]

I finally go with

#serde(default)
address: String,

which lead to empty string if it isn't in xml...

In that case you should also add

#[serde(skip_serializing_if = "String::is_empty")]

[cfconrad]

valid point.

Lets see if this agama-project#983 gets accepted, then I go back to Option<String>