handle uuid decode for smbios 2.6+ #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #48
Looking at
dmidecodeutility apparently as of version 2.6 of the SMBIOS specification, the first 3 fields of the UUID are supposed to be encoded on little-endian. Thedmidecodeutility does not swap bytes for smbios < 2.6 and I think we should be consistent with it.I think this is a very obscure thing and we should completely hide this complexity to the users of the library returning an already parsed
Uuidtype in the specific format. This will avoid any doubt to anyone including smbios gurus.Regarding the implementation I created a private transparent new type wrapper to use instead of plain
[u8; 16]. And then the wrapper decodes the uuid field using the smbios version.It leverage the type system to safely handle the conversion even for potential new smbios revisions with other fields and the compiler inlines the specific implementation in the top level branch skipping the second version compare.
This is the best solution I had to avoid any future errors and with zero cost abstraction.