Add support for Wrap Tokens v1 #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the token; investigating further
…Kafka rejects connection). Investigating
… has correct length byte set
|
@jcmturner would appreciate if this PR could be reviewed and accepted :) if anything else needs to be done on this one - let me know & I'd try to get it all sorted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
This was tested against life Cloudera Kafka clusters (multiple versions) and everything is working nicely
I'm not the greatest Go expert, so if there are any issues with the code, let me know & I'd get it fix asap
Really kin to get this one merged, so Sarama can also get patched, which in turn would allow other applications in our stack to receive the fix