Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat an address slice containing only a NetBIOS address as empty #492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Treat an address slice containing only a NetBIOS address as empty #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7fe094
Treat an address slice containing only a NetBIOS address as empty
bolkedebruin Oct 12, 2022
35cd1bd
Merge branch 'master' into fix_netbios
bolkedebruin Apr 13, 2023
81e12f1
Merge branch 'master' into fix_netbios
bolkedebruin Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions types/HostAddress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,13 @@ func HostAddressesEqual(h, a []HostAddress) bool {
}

// HostAddressesContains tests if a HostAddress is contained in a HostAddress slice.
// Treat an address slice containing only a NetBIOS addresses
// as empty, because we presently have no way of associating
// a client with its NetBIOS address.
func HostAddressesContains(h []HostAddress, a HostAddress) bool {
if len(h) == 1 && h[0].AddrType == addrtype.NetBios {
return true
}
for _, e := range h {
if e.Equal(a) {
return true
Expand Down
6 changes: 6 additions & 0 deletions v8/types/HostAddress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,13 @@ func HostAddressesEqual(h, a []HostAddress) bool {
}

// HostAddressesContains tests if a HostAddress is contained in a HostAddress slice.
// Treat an address slice containing only a NetBIOS addresses
// as empty, because we presently have no way of associating
// a client with its NetBIOS address.
func HostAddressesContains(h []HostAddress, a HostAddress) bool {
if len(h) == 1 && h[0].AddrType == addrtype.NetBios {
return true
}
for _, e := range h {
if e.Equal(a) {
return true
Expand Down