Commits on Feb 16, 2021

1. fix shrinking of prioritized paths …

   HAProxy Ingress since v0.11 implements path types other then `begin`
   (the one from v0.10 and olders) and some sort of `regex` (when a regex
   alias or a wildcard hostname is used) since v0.11. Now we have full
   `regex` (may be used in the path of ingress spec), `exact` and `prefix`
   - respectively str and dir from haproxy acl. This also fits ingress v1
   spec.
   
   Up to v0.11.1, overlapping paths were being wrongly routed depending on
   the path type they use. This happens because haproxy doesn't have a
   common list where all the path types can be matched, but instead
   distinct maps that does distinct matches. We were matching `exact`
   first, followed by `prefix`, then `begin` and so `regex`. The first
   map with a match wins. But this would lead to wrong routes if eg one
   have `/api` as prefix and `/api/sub` as begin - a request with
   `/api/sub` would wrongly match `/api` in the prefix map.
   
   v0.11.2 fixes this behavior looking for overlaps and creating extra
   map files if necessary, and move priority matches to it, so in the
   former example haproxy would match `/api/sub` first, and only after that
   would try to match `/api`. v0.11.2 however introduced a bug: the wrong
   path might be removed from the old map, depending on the order and state
   of the other paths in that map. This commit fixes how the internal
   array of paths is changed, and now it removes only the right one.
   
   Should be merged as far as v0.11 where the functionality was first
   implemented.

   

   jcmoraisjr committed Feb 16, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 4c076c2
   • Browse repository at this point

   Copy the full SHA

   4c076c2 View commit details

   Browse the repository at this point in the history