Fix line too long on backend parsing #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAProxy limits the number of arguments and chars per configuration line, respectively in 64 and 2048. These limits can break the backend parsing in the following conditions: a big number of distinct paths or hostnames sharing the same backend, most of them has at least one per-path customized configuration, at least one of them has a distinct configuration. This commit splits a long chain of matching hostname+path references into at most 30 items, and new lines of the same keyword are added until all paths have been matched. Need to be merged up to v0.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAProxy limits the number of arguments and chars per configuration line, respectively in 64 and 2048. These limits can break the backend parsing in the following conditions: a big number of distinct paths or hostnames sharing the same backend, most of them has at least one per-path customized configuration, at least one of them has a distinct configuration.
This commit splits a long chain of matching hostname+path references into at most 30 items, and new lines of the same keyword are added until all paths have been matched.
Need to be merged up to v0.10.