Update deprecated APIs in Docs #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
|
Hi, thank you! It seems pretty good btw. Perhaps |
|
About the todo - lets make this version a k8s v1.14+. I'll add this backward compatibility item in the changelog. |
Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
|
🤦♂️ forgot this one Did a new commit |
|
Thanks! Merging and sorry about the long delay. I'm aware we already have v1, let's update it in another step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Pchevuzinske Katz [email protected]
This PR intends to start using the newer Ingress APIs instead of the deprecated ones.
Instead of using extensions/v1beta1 it will use the newer networking.k8s.io/v1beta1
Right now I'm changing only the docs, there's a need of decision whether the older API will still be supported (as Ingress NGINX) or be fully deprecated in further versions.
Creating a Ingress resource with networking.k8s.io works fine in the current API and Ingress Controller (tested with v1.17.0) and the extensions/v1beta1 will be fully removed from Kubernetes API in version v1.22
TODO