Fix watch-namespace option #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some ingress annotations and command-line options can read resources from other namespaces. The watch-namespace command-line option just filter ingress resources from the informed namespace but all other resources are still read from the whole cluster. The force-namespace-isolation command-line option will enforce the read of just a single namespace, so the admin can configure a more strict permission to the controller's service account. During lister refactor this behavior wasn't properly rewritten and watch namespace wasn't filtering ingress resources from a single namespace. This change fixes this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ingress annotations and command-line options can read resources from other namespaces. The watch-namespace command-line option just filter ingress resources from the informed namespace but all other resources are still read from the whole cluster. The force-namespace-isolation command-line option will enforce the read of just a single namespace, so the admin can configure a more strict permission to the controller's service account.
During lister refactor this behavior wasn't properly rewritten and watch namespace wasn't filtering ingress resources from a single namespace. This change fixes this behavior.