Fix host match with a port number #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request processing are made using the `base` sample (host+path) and sometimes only the Host header is used. Some http clients add the port number in the header, giving something like `domain.local:80` where only the `domain.local` part should be used to match ingress hostnames. This conversion is done using regsub() that matches and removes `:[0-9]+/`. The problem here is the trailing slash: it only exists in the `base` sample and doesn't exist if the host header is used. Should be merged to v0.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request processing are made using the
basesample (host+path) and sometimes only the Host header is used. Some http clients add the port number in the header, giving something likedomain.local:80where only thedomain.localpart should be used to match ingress hostnames. This conversion is done using regsub() that matches and removes:[0-9]+/. The problem here is the trailing slash: it only exists in thebasesample and doesn't exist if the host header is used.Should be merged to v0.8