Make sni optional if a certificate is optional and is not provided #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move acl declaration to the top of TLS section. This is a pre-requisite to optional sni implementation.
The sni extension is mandatory if a client certificate authentication is used. However, if the certificate is optional, the request was falling back to the default backend if sni isn't provided. This commit changes how requests to domains protected by authentication via client cert works: if a client certificate is optional and the request does not provide one, the host header will be used to match a backend. If a certificate is mandatory or a certificate is sent, the sni extension continue to be mandatory and will be used instead. This should be merged to v0.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sni extension is mandatory if a client certificate authentication is used. However, if the certificate is optional, the request was falling back to the default backend if sni isn't provided.
This commit changes how requests to domains protected by authentication via client cert works: if a client certificate is optional and the request does not provide one, the host header will be used to match a backend. If a certificate is mandatory or a certificate is sent, the sni extension continue to be mandatory and will be used instead.
This should be merged to v0.8.