Fix service port lookup #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the backend port to find the correct ServicePort object from the service. The ServicePort name is used to match the Endpoint port name. Finally, the endpoint port number is the right one. ServicePort name is optional only if there is only one port, so if ServicePort.Name == "", the Endpoint port match, otherwise the svcPort and epPort names should match.
jcmoraisjr
force-pushed
the
jm-svc-port-lookup
branch
from
f9d6415
to
dad7b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the backend port to find the correct ServicePort object from the service. The ServicePort name is used to match the Endpoint port name. Finally, the endpoint port number is the right one. ServicePort name is optional only if there is only one port, so if ServicePort.Name == "", the Endpoint port match, otherwise the svcPort and epPort names should match.
Should merge too v0.8
Fix #383