New ingress converter and haproxy types (part 3) #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check in an earlier stage if some tls-auth check is needed, skipping some lookup in maps whenever possible.
Frontends, servers and sockets with only one hostname used the hostname as part of the name. This is an exception use case and would fail if a special char is used, eg on wildcard hostnames.
There are some common operations regarding hostnames and paths, eg iterate in order to create the files on disk and check if the hostname is wildcard or has a regex. Moving them to an object will help to implement such common tasks
HTTP redirect is always configured on HTTP frontend, so removing var and template checks
jcmoraisjr
force-pushed
the
jm-v08-controller-3
branch
from
079a6fc
to
8a72a3d
Compare
Rewrite now happens in a different way when compared with v0.7. reqrep was moved to the backend and the same backend can be the target of more than one host/path_beg combination. The problem happens when different path_beg (ingress->spec->rules[]->http->paths[]->path) uses rewrite-target - and rewrite-target needs the configured path. The current approach is to sort all used paths in reverse order in order to avoid overlaps - eg an /app path before an /app/sub would match an /app/sub/dir request. All reqrep will happen in that order and should avoid that a wrong rewrite happens.
4 tasks
8 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing pieces between parsing ingress resources and reload HAProxy instance.
and external nameSome missing pieces to the next part:
DrainSupport andNbprocRelated with #289 #295
Implements #274