Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the syslog tag to be specified in the config map. #288

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

brianloss
Copy link
Contributor

No description provided.

@jcmoraisjr
Copy link
Owner

Hi, welcome back and thanks again for your support! Two minor changes:

  • Does your use-case need to use the default value in the template? Otherwise I'd suggest you to move default to config.go, following the convention.
  • Please rebase the PR to master, I'll cherry pick before tag the next beta.

@jcmoraisjr jcmoraisjr added this to the v0.7 milestone Jan 21, 2019
@brianloss brianloss changed the base branch from release-0.7 to master January 21, 2019 15:06
@brianloss
Copy link
Contributor Author

No problem. Thanks for pulling these changes in. It definitely makes it easier if I can get to the point where I'm not working off a fork.
Requested changes have been made. No need for the default value to appear in the template, so I moved it to config.go.

@jcmoraisjr
Copy link
Owner

Merging, thanks!

I'd also propose to postpone this to v0.8.

Why I was merging to v0.7? This implementation is simple enough to be considered to be included. Why not anymore? This same feature can be configured with config-global: log-tag xxx.

@jcmoraisjr jcmoraisjr merged commit fab39a1 into jcmoraisjr:master Jan 22, 2019
@jcmoraisjr jcmoraisjr modified the milestones: v0.7, v0.8 Jan 22, 2019
@brianloss brianloss deleted the log-tag branch January 22, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants