Merged
Conversation
Gateway API uses distinct wildcard hostname match on HTTP and TLS: * Host header and HTTPRoute hostnames matching understand a wildcard as one or more DNS labels, so the wildcard hostname is used as a suffix; * TLS SNI extension and TLSRoute hostnames matching understand a wildcard as a single DNS label, following RFC-2818. Context: https://github.com/kubernetes-sigs/gateway-api/blob/8f9b904306371cbfed9f9d542e9af667de804286/site-src/concepts/hostnames.md?plain=1#L142-L145 kubernetes-sigs/gateway-api#4437 (comment) TLSRoute was not following this configuration, but instead the suffix approach of the HTTPRoute, making one of the conformance tests to fail. This update configures ExtendedWildcard to false, so HAProxy configures the TLS/SNI match using single DNS label instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gateway API uses distinct wildcard hostname match on HTTP and TLS:
Context:
https://github.com/kubernetes-sigs/gateway-api/blob/8f9b904306371cbfed9f9d542e9af667de804286/site-src/concepts/hostnames.md?plain=1#L142-L145
kubernetes-sigs/gateway-api#4437 (comment)
TLSRoute was not following this configuration, but instead the suffix approach of the HTTPRoute, making one of the conformance tests to fail. This update configures ExtendedWildcard to false, so HAProxy configures the TLS/SNI match using single DNS label instead.