Made library compatible with both Unix and Windows versions of gpg-agent #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly this took me about an hour to do this morning, so it might need a bit more looking over. But essentially this adds support for Windows gpg-agent into this library.
I added the support by using compile-time flags in
gpgagent_unix.go
andgpgagent_windows.go
so that a different version ofNewGpgAgentConn
gets compiled in depending on which platform you compile with.Because Windows does not have Unix sockets, and gpg-agent doesn't use named pipes (rather it binds a localhost TCP socket), the Windows version:
127.0.0.1:port
I've only done limited testing, but it works great in the examples I've tried.