-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip install cirrus #59
base: master
Are you sure you want to change the base?
Conversation
I think we should rename all the files with spaces in the name (and use underscores instead). The changes seem reasonable. @andrewmzhang Can you also check this? |
python/frontend/LICENSE
Outdated
@@ -0,0 +1,19 @@ | |||
Copyright (c) 2018 The Python Packaging Authority |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to make this the Apache License, to match the License of cirrus (c++)
python/frontend/setup.py
Outdated
setuptools.setup( | ||
name="cirrus", | ||
version="0.0.2", | ||
author="jcarreira", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think by convection this is the author's name, not username.
I actually wrote a version of setup.py a while back, but never submitted a proper PR for it. Pick and choose what you need from here.
you should probably take the first 5 lines from my file as well as license=open('LICENSE') and the packages=find_packates(exclude=('test', 'docs')). Everything else is good.
python/frontend/setup.py
Outdated
packages=setuptools.find_packages(), | ||
classifiers=( | ||
"Programming Language :: C++", | ||
"License :: OSI Approved :: MIT License", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should be Apache (mentioned above)
We should bring this PR up to date because some things here were added in a recent PR from @andrewmzhang (namely LICENSE, setup,py, ..). |
No description provided.