pip install cirrus #59
Conversation
|
I think we should rename all the files with spaces in the name (and use underscores instead). The changes seem reasonable. @andrewmzhang Can you also check this? |
python/frontend/LICENSE
Outdated
| @@ -0,0 +1,19 @@ | |||
| Copyright (c) 2018 The Python Packaging Authority | |||
There was a problem hiding this comment.
You might want to make this the Apache License, to match the License of cirrus (c++)
python/frontend/setup.py
Outdated
| setuptools.setup( | ||
| name="cirrus", | ||
| version="0.0.2", | ||
| author="jcarreira", |
There was a problem hiding this comment.
I think by convection this is the author's name, not username.
I actually wrote a version of setup.py a while back, but never submitted a proper PR for it. Pick and choose what you need from here.
you should probably take the first 5 lines from my file as well as license=open('LICENSE') and the packages=find_packates(exclude=('test', 'docs')). Everything else is good.
python/frontend/setup.py
Outdated
| packages=setuptools.find_packages(), | ||
| classifiers=( | ||
| "Programming Language :: C++", | ||
| "License :: OSI Approved :: MIT License", |
There was a problem hiding this comment.
Probably should be Apache (mentioned above)
|
We should bring this PR up to date because some things here were added in a recent PR from @andrewmzhang (namely LICENSE, setup,py, ..). |
No description provided.