#39 Create my-default.cnf in basedir #42
Conversation
|
@dmarkov please, find someone to review |
|
Travis failed to build because of |
|
Many thanks for the PR, let me find a reviewer for it |
|
@yegor256 please review this PR |
| @@ -256,7 +256,8 @@ private File prepareFolders(final File target) throws IOException { | |||
| private File data(final File dist, final File target) throws IOException { | |||
| final File dir = new File(target, DATA_SUB_DIR); | |||
| if (!dir.exists()) { | |||
| final File cnf = new File(target, "my-default.cnf"); | |||
| final File support = new File(dist, "support-files"); | |||
There was a problem hiding this comment.
why this one-time variable? see http://www.yegor256.com/2014/04/27/typical-mistakes-in-java-code.html#one-time-variables
|
@yegor256 you are right, fixed |
|
@longtimeago just curious, isn't possible at all to reproduce the problem first? somehow... I mean, in an automated way |
|
well, it's not reproduced on linux at all, so as far as we have no CI PC with Windows we can't add a test for it. |
|
Not possible with Travis :( http://stackoverflow.com/questions/19818336/travis-ci-test-package-for-linux-osx-windows |
|
I know ... and I'm happy :) |
|
I think this is what we need: http://www.appveyor.com/ |
|
It's a CI service for .Net apps, which means they run on Windows :) I'll give it a try now |
|
OMG ... they are masochist |
|
we're there already: https://ci.appveyor.com/project/yegor256/jcabi-mysql-maven-plugin I'll try to configure it so that we can reproduce the problem first... |
|
@yegor256 looks like this CI service needs more configuration |
|
yeah, a lot more. we should download and run Maven from msbuild |
|
PR is outdated .. closing |
|
@yegor256 Much obliged! I've added 30 mins to your account in payment "000-d064b0ae" |
|
@rultor please deploy |
No description provided.