Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOGTOOL-159 - Allow jboss-logging-processor to operate as an incremental processor in Gradle builds #113

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

sebersole
Copy link
Contributor

@sebersole sebersole commented Jun 14, 2024

LOGTOOL-159 - Allow jboss-logging-processor to operate as an incremental processor in Gradle builds

@sebersole sebersole requested a review from jamezp as a code owner June 14, 2024 13:24
@jamezp jamezp changed the title JBLOGGING-186 - Allow jboss-logging-processor to operate as an incremental processor in Gradle builds LOGTOOL-159 - Allow jboss-logging-processor to operate as an incremental processor in Gradle builds Jun 14, 2024
@jamezp jamezp merged commit 96431d6 into jboss-logging:main Jun 18, 2024
9 checks passed
@sebersole
Copy link
Contributor Author

Thanks for applying my PR James!

Any idea which version we can expect the fix in? It causes really painful compile times in Hibernate.

@jamezp
Copy link
Member

jamezp commented Jun 28, 2024

@sebersole I'll try to get a release out later today or early next week. I know there are some other changes needed/wanted too :)

@sebersole
Copy link
Contributor Author

@sebersole I'll try to get a release out later today or early next week. I know there are some other changes needed/wanted too :)

Thanks!

@jamezp
Copy link
Member

jamezp commented Jul 3, 2024

@sebersole Released https://github.com/jboss-logging/jboss-logging-tools/releases/tag/3.0.0.Final

@sebersole
Copy link
Contributor Author

@jamezp Given that its a major I'm a little worried about the ability to use this in Hibernate considering all the environments it is used in. Any thoughts on that? Is the processor from 3.0.0 usable with older versions of the api/annotations?

@sebersole
Copy link
Contributor Author

At the moment, Hibernate uses -

  • jboss-logging - 3.5.0.Final
  • jboss-logging-annotations - 2.2.1.Final
  • jboss-logging-processor - 2.2.1.Final

So would it be safe to drop in 3.3.0 for jboss-logging-annotations and jboss-logging-processor and keep using 3.5.0.Final for jboss-logging? I'll tias, but if you know...

@jamezp
Copy link
Member

jamezp commented Jul 3, 2024

There shouldn't be a problem using 3.0.0.Final of tooling and annotations with older versions of the logging facade. If you find any though, please feel free to let me know :)

There was an issue using the 2.2.1.Final annotations with the 3.0.0.Final processor, but I wouldn't suggest that anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants