Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Add support for Azure SQL Temporal Tables #94

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

gebirgslok
Copy link
Contributor

This PR fixes #86

  • Replaced IDbAdapter.SupportsTemporalTables property with IDbAdapter.CheckSupportsTemporalTables method
  • Added default implementation (no support for temporal tables) in order to not break code for users who implemented their own IDbAdapter
  • Removed Checkpoint.DoesDbSupportsTemporalTables method which is SQL Server specific
  • Checkpoint.BuildDeleteTables utilizes new method
  • Fixed the incorrect check whether SQL Server supports Temporal Tables (as mentioned in the issue)

Please let me know if something is wrong or missing.

Best

… method

Replaced the SupportsTemporalTables flag with an awaitable method that receives the DbConnection arg and
return a boolean indicating whether or not the underlying DB supports Temporal Tables.
Adjusted all IDbAdapter implementations and used the (incorrect) existing one for SQL server.

The CheckSupportsTemporalTables  method has a default implementation to not break code
for users who have written their own IDbAdapter.
@jbogard jbogard merged commit 57a9273 into jbogard:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporal Tables and Azure SQL
2 participants