Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string concatenation when build oracle table/relation command text #114

Merged

Conversation

MingMZ
Copy link
Contributor

@MingMZ MingMZ commented Feb 14, 2023

Fixes #113

Reason for fix is to correct string concatenation of command text in OracleDbAdapter.cs.

I also renamed Checkpoint to Respawner in OracleTests.cs; added test cases when include/exclude {schema}.{table}.

@MingMZ MingMZ marked this pull request as ready for review February 14, 2023 13:38
@jbogard
Copy link
Owner

jbogard commented Feb 14, 2023

Were you able to make the tests pass?

@MingMZ
Copy link
Contributor Author

MingMZ commented Feb 14, 2023

I did run oracle test, with podman spin up an oracle instance.

dotnet test .\Respawn.DatabaseTests\ --nologo --filter OracleTests --results-directory test-results
  Determining projects to restore...
  All projects are up-to-date for restore.
  Respawn -> C:\Projects\Respawn\Respawn\bin\Debug\netstandard2.1\Respawn.dll
  Respawn.DatabaseTests -> C:\Projects\Respawn\Respawn.DatabaseTests\bin\Debug\net6.0\Respawn.DatabaseTests.dll
Test run for C:\Projects\Respawn\Respawn.DatabaseTests\bin\Debug\net6.0\Respawn.DatabaseTests.dll (.NETCoreApp,Version=v6.0)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed!  - Failed:     0, Passed:    13, Skipped:     0, Total:    13, Duration: 2 m 26 s - Respawn.DatabaseTests.dll (net6.0)

Forgot to mention, unsure of the reason, I left #if !ORACLE preprocessor unchanged in OracleTests.cs.

@jbogard jbogard merged commit 7178126 into jbogard:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oracle error while creating respawner when include table with schema name
2 participants