Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added linking feature #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Fresheyeball
Copy link

That ability to close gitter notifications is preserved, and linking is configurable

Isaac Shapira added 3 commits January 31, 2013 00:04
…ottom elements removed, css updated to provide rounded corners and transparency via css3
@@ -111,7 +111,8 @@
sticky = params.sticky || false,
item_class = params.class_name || $.gritter.options.class_name,
position = $.gritter.options.position,
time_alive = params.time || '';
time_alive = params.time || '',
href = params.href || '#';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if someone scrolls half way down the page, then clicks on the gritter message and href == '#', it'll jump to the top, right? If so, that needs to be stopped from happening.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are correct sir. I will modify.

On Mar 16, 2013, at 4:40 PM, Jordan Boesch [email protected] wrote:

In js/jquery.gritter.js:

@@ -111,7 +111,8 @@
sticky = params.sticky || false,
item_class = params.class_name || $.gritter.options.class_name,
position = $.gritter.options.position,

  •           time_alive = params.time || '';
    
  •           time_alive = params.time || '',
    
  •           href = params.href || '#';
    
    So if someone scrolls half way down the page, then clicks on the gritter message and href == '#', it'll jump to the top, right? If so, that needs to be stopped from happening.


Reply to this email directly or view it on GitHub.

@Fresheyeball
Copy link
Author

I tested in ie7/8 and it works. However I moved the rounded corners to css3 instead of image, which means that ie7/8 will have square corners. Is this acceptable to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants