Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font fallback on Edge because of missing MIME type #308

Closed
timsneath opened this issue May 9, 2017 · 4 comments
Closed

Font fallback on Edge because of missing MIME type #308

timsneath opened this issue May 9, 2017 · 4 comments

Comments

@timsneath
Copy link

timsneath commented May 9, 2017

On Edge, the embedded fonts used for charts aren't rendering correctly, but are falling back to a default. This seems to be because the MIME type isn't specified for the stylesheet references in highchart.js and highchart2.js.

On Edge 40:
edge

On Chrome 57:
chrome

Per the HTML5 standard for the link element, a type is not required, but if it is specified, "the value must be a valid MIME type".

timsneath pushed a commit to timsneath/highcharter that referenced this issue May 9, 2017
@jbkunst
Copy link
Owner

jbkunst commented May 9, 2017

@timsneath,

Oh, my fault! I forgot add the MIME type. Thank you very much.

PR accpeted.

jbkunst added a commit that referenced this issue May 9, 2017
@jbkunst jbkunst added this to the v0.5.1 milestone May 9, 2017
@jbkunst
Copy link
Owner

jbkunst commented May 9, 2017

closed in #309

@jbkunst jbkunst closed this as completed May 9, 2017
@timsneath
Copy link
Author

Thanks so much!

@jbkunst
Copy link
Owner

jbkunst commented May 9, 2017

No! Thanks to YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants