cmake: make yaml-cpp package relocatable#446
Closed
sergiud wants to merge 1 commit intojbeder:masterfrom
Closed
Conversation
|
+1 This solved my issue with propagating include paths on the I can't speak to the change in |
Collaborator
|
seems to be fixed in $475 or #538. Please feel free to reopen if issue continues to exists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
yaml-cpp-config.cmakerelocatable allowing the package to be used both from the build tree and the install path. The changes are backwards compatible.Typical usage of
yaml-cpp-config.cmake:The
yaml-cpp-config.cmakeis now always installed under${CMAKE_INSTALL_PREFIX}/(lib|lib64)/cmake/yaml-cpp. This change was necessary to simplify the config logic. Previously,yaml-cpp-config.cmakewas installed under${CMAKE_INSTALL_PREFIX}/CMakefor Win32 (excluding cygwin), and${CMAKE_INSTALL_PREFIX}/(lib|lib64)/cmake/yaml-cppon other platforms. The different config paths that depend on the platform in use are unnecessary.