Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes, refactoring and new features #5

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

fcrespel
Copy link
Contributor

Hello,

Here are two small fixes for Ruby 1.8 and for the login button URL when Redmine is installed in a subdirectory (e.g. example.org/redmine)

@fcrespel
Copy link
Contributor Author

While I was at it, I also implemented a few features I needed :

  • Allow disabling CAS authentication globally.
  • Allow replacing the default Redmine login page with CAS.
  • On-the-fly user registration, with support for firstname/lastname/mail CAS attributes, self-registration form when attributes are missing, and association with an existing LDAP auth source in case you need to disable CAS later.

Feel free to pull/cherry-pick/rework this set of commits as you see fit :-)

@jbbarth
Copy link
Owner

jbbarth commented Jan 21, 2013

Wow, that's a bunch of work, thanks! I'll try to test everything in the next 2 weeks and then merge it.

@jbbarth
Copy link
Owner

jbbarth commented Feb 7, 2013

I cherry-picked 7 of the 8 first commits and pushed them to master.

I don't really understand a0a0bd2 : sure monkey patching is useful in Redmine plugins, but here OmniAuth accepts a proc for being dynamically configured, so I don't really see the point. Plus it changes the behaviour of the original code, which relies on Setting["host_name"] to avoid some reverse-proxy issues. Standard OmniAuth's full_host method has the usual problems in reverse-proxyfied environments IIRC.

The last 3 commits will be added soon but I want to add some tests for them, as the change is a bit more risky and needs to be maintained in future versions. I will post updates here.

Thanks again for all that work on the plugin!

jbbarth and others added 8 commits July 12, 2015 18:54
…rily a HashWithIndifferentAccess + missing some things for CAS logout url)
ActionDispatch::Callbacks.to_prepare reloads code on every requests, which is
the desired behaviour in development mode. The other version introduced by
b1d89ee only reloads code when Rails configures itself. Hence, when an
other plugin patches the same classes/modules, the patches introduced by
this plugin disappear so everything is broken in development mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants