-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes, refactoring and new features #5
base: master
Are you sure you want to change the base?
Conversation
…S, to retain default behavior when 'omniauth.origin' is not available
…e of redirecting to the origin URL.
- Support firstname/lastname/mail CAS attributes. - Show self-registration form when attributes are missing. - Optionally associate newly created user with an existing LDAP auth source, in case you need to disable CAS later. - Make all this configurable in plugin settings.
While I was at it, I also implemented a few features I needed :
Feel free to pull/cherry-pick/rework this set of commits as you see fit :-) |
Wow, that's a bunch of work, thanks! I'll try to test everything in the next 2 weeks and then merge it. |
I cherry-picked 7 of the 8 first commits and pushed them to master. I don't really understand a0a0bd2 : sure monkey patching is useful in Redmine plugins, but here OmniAuth accepts a proc for being dynamically configured, so I don't really see the point. Plus it changes the behaviour of the original code, which relies on The last 3 commits will be added soon but I want to add some tests for them, as the change is a bit more risky and needs to be maintained in future versions. I will post updates here. Thanks again for all that work on the plugin! |
…rily a HashWithIndifferentAccess + missing some things for CAS logout url)
ActionDispatch::Callbacks.to_prepare reloads code on every requests, which is the desired behaviour in development mode. The other version introduced by b1d89ee only reloads code when Rails configures itself. Hence, when an other plugin patches the same classes/modules, the patches introduced by this plugin disappear so everything is broken in development mode.
Hello,
Here are two small fixes for Ruby 1.8 and for the login button URL when Redmine is installed in a subdirectory (e.g. example.org/redmine)