Ensure the core tests pass with Redmine 4.2.11

jbbarth · Jun 20, 2024 · bbd69a9 · bbd69a9
1 parent 9f1e093
commit bbd69a9
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/redmine_comments/journal_patch.rb b/lib/redmine_comments/journal_patch.rb
@@ -30,8 +30,12 @@ def journal_attachments
   end
 
   def standard_attachments_method
-    ids = details.select {|d| d.property == 'attachment' && d.value.present?}.map(&:prop_key)
-    Attachment.where(id: ids).sort_by {|a| ids.index(a.id.to_s)}
+    if Redmine::VERSION::MAJOR >= 5
+      ids = details.select {|d| d.property == 'attachment' && d.value.present?}.map(&:prop_key)
+      Attachment.where(id: ids).sort_by {|a| ids.index(a.id.to_s)}
+    else
+      journalized.respond_to?(:attachments) ? journalized.attachments : []
+    end
   end
 
   # Returns a SQL condition to filter out journals with notes that are not visible to user