Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Simpler managers implementation #3

Closed
wants to merge 1 commit into from
Closed

Simpler managers implementation #3

wants to merge 1 commit into from

Conversation

fulldecent
Copy link

No description provided.

@eordano
Copy link

eordano commented Feb 5, 2018

This has the disadvantage of having a set of interfaces that can never be implemented (one in 2^32 signatures will conflict with the 0xffffffff hash). I'd vote against merging this.

@jbaylina
Copy link
Owner

jbaylina commented Feb 5, 2018

I don't see the advantage of this PR.
1.- The code is not simpler. (More lines and more complex)
2.- You are reusing a variable for another thing. (confusing).

@fulldecent
Copy link
Author

Closing. This PR is useless.

@fulldecent fulldecent closed this Feb 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants