Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize packaging using pyproject.toml #759

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Aug 20, 2024

This PR is modernizing packaging using pyproject.toml, a recommended way for Python projects. Please see https://packaging.python.org/en/latest/guides/modernize-setup-py-project/.

I also added py38-build env in tox, so with every change it'll package and check if it's distributable using twine.

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Aug 20, 2024

Tests are failing due to Docker Hub rate limit, I'll try a bit later. The build job results are available at https://github.com/jazzband/sorl-thumbnail/actions/runs/10470480254/job/28995717721?pr=759

tox.ini Outdated Show resolved Hide resolved
@dulmandakh dulmandakh force-pushed the modernize-packaging-pyproject branch from 36876c8 to a1430c0 Compare August 20, 2024 15:04
tox.ini Outdated Show resolved Hide resolved
@dulmandakh
Copy link
Contributor Author

dulmandakh commented Aug 31, 2024

@claudep merged master, including your pytest changes.

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@claudep claudep merged commit f00421d into jazzband:master Aug 31, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants