Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #691 - Obsolete THUMBNAIL_KVSTORE #692

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Mar 1, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #692 (1069524) into master (f62c617) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   73.75%   73.80%   +0.04%     
==========================================
  Files          30       30              
  Lines        1688     1691       +3     
==========================================
+ Hits         1245     1248       +3     
  Misses        443      443              
Impacted Files Coverage Δ
sorl/thumbnail/kvstores/base.py 95.00% <100.00%> (+0.20%) ⬆️
sorl/thumbnail/kvstores/cached_db_kvstore.py 93.47% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62c617...1069524. Read the comment docs.

@claudep
Copy link
Contributor Author

claudep commented Mar 1, 2022

Please just wait a bit before reviewing this patch, there are some things I'd want to check before going forward.

@uri-rodberg
Copy link
Contributor

Please just wait a bit before reviewing this patch, there are some things I'd want to check before going forward.

@claudep Convert this PR to draft? It's from 2022.

@dulmandakh
Copy link
Contributor

@claudep Django 3.x is no longer maintained, so we only have Django versions that supports Redis cache. Removing non-supported Django versions in #754.

How I can help with this PR?

@dulmandakh
Copy link
Contributor

dulmandakh commented Aug 20, 2024

@claudep how about remove the support without deprecating and release major release with a breaking change 😉

@claudep
Copy link
Contributor Author

claudep commented Aug 20, 2024

I think we can release a 12.x version with the deprecation, and not so long after release a 13.x version with the removals.

Copy link
Contributor

@dulmandakh dulmandakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dulmandakh
Copy link
Contributor

@claudep may I merge this PR, it looks good to me.

@claudep
Copy link
Contributor Author

claudep commented Aug 31, 2024

Thanks for the review!

@claudep claudep merged commit 452ceb0 into jazzband:master Aug 31, 2024
32 checks passed
@claudep claudep deleted the depr_kvs branch August 31, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants